search

lyft / clutch

Extensible platform for infrastructure management
https://clutch.sh
Apache License 2.0
1.7k stars 120 forks source link

frontend: Refactor workflows to use new layout #3159

Closed septum closed 2 weeks ago

septum commented 3 weeks ago

Description

Screenshots

Standard Layout

Before

clutch lyft net_catalog_ (1)

After

localhost_3000_catalog_testbuildnotify

[!NOTE] New props were added to the layout to display only the breadcrumbs and preserve previous route component header

Wizard Layout

Before

clutch lyft net_dash_ (1)

After

localhost_3000_catalog

No Layout

Before

clutch lyft net_dash_

After

localhost_3000_dash

Testing Performed

Manual

jdslaugh commented 3 weeks ago

@septum looking at this:

localhost_3000_catalog_testbuildnotify

Curious why Catalog is black and the project name is blue. Would think it was the other way around since the route looks to be on the project versus the main catalog

septum commented 3 weeks ago

@septum looking at this:

localhost_3000_catalog_testbuildnotify

Curious why Catalog is black and the project name is blue. Would think it was the other way around since the route looks to be on the project versus the main catalog

This is because the comment above:

There's an issue with the list of workflow paths available:

  • When rendering the workflow paths not all possible routes are not available to this check, because some workflows are fragmented between instances but not reconciled into one single workflow.

Basically, when rendering this path, the /catalog/ root path is not available, because it's in another instance of clutch. I added another check to manually add the /${route.path}, but it was providing some root paths that did not have a component.