search

lyft / cni-ipvlan-vpc-k8s

AWS VPC Kubernetes CNI driver using IPvlan
Apache License 2.0
360 stars 58 forks source link

add --random-fully to MASQUERADE rule to reduce the chance of insertion failure #58

Closed dbyron0 closed 5 years ago

dbyron0 commented 5 years ago

See https://tech.xing.com/a-reason-for-unexplained-connection-timeouts-on-kubernetes-docker-abd041cf7e02 for background.

paulnivin commented 5 years ago

@dbyron0 Thanks for the fix! Can you please sign the CLA so we can merge this fix and push out a new release?

dbyron0 commented 5 years ago

I signed it, but the check still shows as failing. When I click on details above (https://oss.lyft.com/cla/) it says "Signed and current (1.0)"

dbyron0 commented 5 years ago

I can push e.g. an empty commit to the branch if that helps.

dbyron0 commented 5 years ago

Welp, that didn't help. Removing it...

paulnivin commented 5 years ago

Will get this merged soon. Thanks again for the patch.

dbyron0 commented 5 years ago

Happy to help.

paulnivin commented 5 years ago

Can you try amending your commits? git commit --amend --author="David Byron <dbyron@dbyron.com>"

dbyron0 commented 5 years ago

Aaah yes. Sorry for the trouble.

lbernail commented 5 years ago

Very good idea! This issue was a lot worse for us when we used kube-proxy in iptables mode