lyft / cni-ipvlan-vpc-k8s

AWS VPC Kubernetes CNI driver using IPvlan
Apache License 2.0
360 stars 58 forks source link

[README] Change example containerInterface for cadvisor #63

Closed lbernail closed 4 years ago

lbernail commented 5 years ago

cadvisor ignores interfaces prefixed with veth which means the kubelet network metrics do not include the interface to the host and are incomplete: https://github.com/google/cadvisor/blob/master/container/libcontainer/handler.go#L236-L247

Solving this is easy and simply involve changing the containerInterface name. I think most users of the plugin start with the configuration example from the README (we certainly did) so having a name that works with cadvisor there makes sense.