lyft / cni-ipvlan-vpc-k8s

AWS VPC Kubernetes CNI driver using IPvlan
Apache License 2.0
360 stars 58 forks source link

Inherit MTU from main interface #66

Closed lbernail closed 5 years ago

lbernail commented 5 years ago

The MTU of secondary ENIs was based on interface eth0 which does not exist on ubuntu instances. This PR retrieves the name of the primary interface from the interface list instead.

In addition, when the MTU was not set in the PTP plugin, the veth was configured with the system defaults (usually 1500). This PR instead defaults to the MTU of the hostInterface.

The goal is that all interfaces created by the plugins inherit the MTU from the main interface (to allow for jumbo frames in the VPC).

I think these defaults should work for all use cases, let me know what you think

lbernail commented 5 years ago

@theatrus or @paulnivin Could you have a look? (we have been running this for a while and it works fine but we'd like to avoid maintaining a fork)

Thanks!

lbernail commented 5 years ago

Thanks!