lyft / cni-ipvlan-vpc-k8s

AWS VPC Kubernetes CNI driver using IPvlan
Apache License 2.0
360 stars 58 forks source link

Use the AWS API to retrieve instance network limits #78

Closed lbernail closed 4 years ago

lbernail commented 4 years ago

This PR has 2 commits:

Dynamically get instance network limits

Propagate errors due to network limits When an instance was unknown, ENILimits used to return {0,0,0} which was a bit confusing in runtime log. The other commit makes an API call to AWS so we can face new errors. This commits propagate errors to ENILimits callers to make them explicit

theatrus commented 4 years ago

:excited!:

Let me give this a quick spin.

lbernail commented 4 years ago

@theatrus My tests went fine, let me know if you see any problem on your side

theatrus commented 4 years ago

Been a busy few weeks here, but this looks good to me. Merging and thank you!!