search

lyft / flinkk8soperator

Kubernetes operator that provides control plane for managing Apache Flink applications
Apache License 2.0
569 stars 159 forks source link

ingress configuration 'ingressAnnotations' and 'ingressTLSSecretName' #188

Open Smana opened 4 years ago

Smana commented 4 years ago

In order to be able to configure the ingresses this PR allows to set annotations and the TLS secret name to retrieve the certificates.

fixes https://github.com/lyft/flinkk8soperator/issues/131

Smana commented 4 years ago

By the way, I've updated the CRD manually but there may be a way to automatically generate it. Please let me know

vDMG commented 4 years ago

@anandswaminathan or someone can take a look at this PR plz ?

kumare3 commented 4 years ago

I will work with one of them and take a look. Sorry if this has gone stale. I think people just missed it

schmichri commented 3 years ago

Bump as it would be really handy to set ingress annotations.

maccamlc commented 3 years ago

Oh, I was looking at https://github.com/lyft/flinkk8soperator/pull/230

Think ingressClassName also needed now, and I would definitely appreciate this capability :)

mootezbessifi commented 2 years ago

why until now, this PR was not accepted and merged?? It is very important to manage annotations in ingress in terms of Auth and ssl configs !!

mootezbessifi commented 2 years ago

@mwylde @glaksh100 @kumare3 @anandswaminathan could you support here please

bagipriyank commented 3 months ago

new version of nginx seems to need annnotation kubernetes.io/ingress.class: nginx on the ingress. would really appreciate if we can resolve the merge conflicts here, and merge and release this.