search

lyft / flinkk8soperator

Kubernetes operator that provides control plane for managing Apache Flink applications
Apache License 2.0
569 stars 159 forks source link

Use Go Modules #274

Closed danielmmetz closed 1 year ago

danielmmetz commented 1 year ago

And while we're at it, upgrade to Go 1.20. In the process I had to change a lot of the dependencies. Some because the dependencies wouldn't resolve using Go modules, some because they were incompatible with others. The long and the short of it is: 1) the kubernetes dependency ecosystem is very rough and 2) this should be carefully validated during rollout given the number of dependency shifts.

Some other minor notes include some lint changes, or rewriting a very small bit of code to drop a dependency to have one less to fight with.

anandswaminathan commented 1 year ago

@danielmmetz wondering what's happening with integration tests.

anandswaminathan commented 1 year ago

@danielmmetz Not sure how to validate this without - https://github.com/lyft/flinkk8soperator/blob/master/.github/workflows/actions.yml#L50

Want to reenable ?

anandswaminathan commented 1 year ago

PTAL @leoluoInSea

leoluoInSea commented 1 year ago

@danielmmetz wondering what's happening with integration tests.

The integ tests are failing. I was trying to debug this and fix the issue, I was able to narrow down the problem is Flink app is stuck at deleting after every test till test time out. However I was unable to figure out why this happened and how to fix it yet. @anandswaminathan