lyft / metadataproxy

A proxy for AWS's metadata service that gives out scoped IAM credentials from STS
Other
456 stars 69 forks source link

Refactorator: Apply setdeploystepenvironment in metadataproxy #104

Closed lyft-refactorator closed 4 years ago

lyft-refactorator commented 4 years ago

Refactorator would like to apply these changes to your code! Please shepherd this to production as soon as possible, going through the normal deployment process monitoring this PR as you would any other change.

You do not need to approve or land this PR. It will be merged automatically. You will still need to deploy the merged commit yourself.

To reproduce these changes locally, run:

control ensure control.minimal
control run refactorator.run fix -i metadataproxy -f setdeploystepenvironment

setdeploystepenvironment

This refactorator adds an environment to deploy steps where it can be trivially inferred (e.g. the name already contains a valid environment). Deploy steps whose names cannot be trivially inferred will be skipped for now in favor of revisiting later. This enables the Deploys team to rely on explicit info instead of parsing deploy names.

For more information or questions reach out to #deploys-bots.

asubrocky commented 4 years ago

/merge