search

lyft / metadataproxy

A proxy for AWS's metadata service that gives out scoped IAM credentials from STS
Other
456 stars 69 forks source link

Handle cached containers that are stopped #20

Closed jordanrasmussen closed 8 years ago

jordanrasmussen commented 8 years ago

Pull Request for Issue #19

This change checks to see if the cached container is running and if its not, removes it from the cache.

This will 1, prevent returning the role for the last container that had it's ip address and 2 help keep the cache clean of stopped containers.

justinwatkinson commented 8 years ago

Jordan is the "other guy" I was talking about in issue #19 :+1:

ryan-lane commented 8 years ago

Hey @jordanrasmussen, this looks great. Before I can merge this in, you'll need to sign our CLA, which can be signed here: https://oss.lyft.com/cla/#/signature

Thanks for sending in a PR!

jordanrasmussen commented 8 years ago

@ryan-lane, CLA has been signed.

ryan-lane commented 8 years ago

Cool. I'm doing a bit of quick manual testing here first, then I'll merge it in.

ryan-lane commented 8 years ago

Nice work! Thanks again!