Closed sharganMedallia closed 7 years ago
This is great! Thanks for the PR. Before we can accept this, we need you to sign our CLA:
Let me know when you've signed and I can merge this in.
@sharganMedallia did you get a chance to look at the CLA?
Sorry for the delayed response. I'm working with my company's legal team now to ensure that everything's in order and it's taking a little longer than I'd hoped. Will keep you posted!
Awesome. Thanks for the update. No rush :)
Any update @sharganMedallia?
For now we're going to close this PR out, @sharganMedallia, but we can open it back up at any point if you sign the CLA.
As currently written, using an older docker version on the server side of the socket raise an exception:
This easily fixed by allowing
docker.Client
to autodetect its version (while still permitting runtime override via the DOCKER_VERSION environment variable). Requests that require an unsupported version are still gated by docker-py'sdocker.utils.minimum_version
decorator.