search

lyft / metadataproxy

A proxy for AWS's metadata service that gives out scoped IAM credentials from STS
Other
456 stars 69 forks source link

Add code to parse Rancher IP from labels #35

Closed garceri closed 7 years ago

garceri commented 7 years ago

This code fixed metadataproxy under Rancher 1.2+ Environments. As discussed on #33

ryan-lane commented 7 years ago

Thanks for the PR! Before we can merge this in we'll need you to sign our CLA at:

https://oss.lyft.com/cla

ryan-lane commented 7 years ago

Can you also make sure this is passing tests? Right now I'm sure it won't pass the lint test. You can test with make test. I'll have to look into why the tests aren't automatically running against this PR.

garceri commented 7 years ago

Working on it

From: Ryan Lane [mailto:notifications@github.com] Sent: Tuesday, February 7, 2017 3:47 PM To: lyft/metadataproxy metadataproxy@noreply.github.com Cc: pythianarceri arceri@pythian.com; Author author@noreply.github.com Subject: Re: [lyft/metadataproxy] Add code to parse Rancher IP from labels (#35)

Can you also make sure this is passing tests? Right now I'm sure it won't pass the lint test. You can test with make test. I'll have to look into why the tests aren't automatically running against this PR.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lyft/metadataproxy/pull/35#issuecomment-278101283, or mute the thread https://github.com/notifications/unsubscribe-auth/AKB8kBca35fjRrvcTZR0WWzG4CI_ItnWks5raLwugaJpZM4L5u6Y .

--

--

ryan-lane commented 7 years ago

Seems travis has pull request tests turned off, so I've turned those back on. On your next push travis will run your tests.

ryan-lane commented 7 years ago

Hey @pythianarceri, have you gotten a chance to followup on this yet?

garceri commented 7 years ago

Closing this one and replacing it with https://github.com/lyft/metadataproxy/pull/61