Refactor for better logging

lyft / metadataproxy

A proxy for AWS's metadata service that gives out scoped IAM credentials from STS

Other

456 stars 69 forks source link

Refactor for better logging #57

Closed josegonzalez closed 5 years ago

josegonzalez commented 7 years ago

use blueprints instead of flask app
made dockerfile builds faster by installing requirements before adding the entire source tree
standardize on a single logging format (which may not be BC if you are expecting it one way in your log aggregation tooling)
added support for bugsnag/sentry

Let me know if you want me to remove anything.

ryan-lane commented 7 years ago

This is a big PR, so it's going to take me a while to fully review :). This looks pretty great overall so far, though. Thanks for the contribution!

josegonzalez commented 6 years ago

I'll need to resolve conflicts, but do we still want these changes, or is there a preferred alternative?

ryan-lane commented 6 years ago

I'd say let's pull this in. It's better than what we currently have and if we want to change how this works later, we can refactor. Sorry this has been sitting so long!

josegonzalez commented 5 years ago

I'm going to close this. For various reasons, we've moved to a golang implementation of metadataproxy, which allowed us to both improve general performance, add telemetry, and simplify codepaths around logging :)