Closed brandond closed 7 years ago
@ryan-lane For some reason your commit tagging 1.3.2 isn't in master, so that got rolled up in here as well since I branched on the 1.3.2 tag. If you want to push to master I can rebase.
I have some comments to be addressed, but overall good PR. The code is getting complicated enough that it's probably a good idea for us to start adding some tests...
Thanks for the contribution btw :)
OK @ryan-lane I think I got everything you asked for. I also fixed the mock routes, since I had forgotten to look at them.
@ryan-lane anything else you need here?
Sorry about the delay. I need to do some manual testing with this.
If it helps any, I've been running it on our GitLab CI box for the last week or so and it's been working great. Probably smaller scale than y'all are running it at though ;)
I'm really sorry for the long wait on this. I'm going to test this properly over the weekend and I think based on a review of the code that it'll be mergeable without change. Thanks again for the code!
Thanks for the contribution!
released in tag 1.5.0