lyft / metadataproxy

A proxy for AWS's metadata service that gives out scoped IAM credentials from STS
Other
456 stars 69 forks source link

Support for additional control over assumed roles #60

Closed brandond closed 7 years ago

brandond commented 7 years ago
brandond commented 7 years ago

@ryan-lane For some reason your commit tagging 1.3.2 isn't in master, so that got rolled up in here as well since I branched on the 1.3.2 tag. If you want to push to master I can rebase.

ryan-lane commented 7 years ago

I have some comments to be addressed, but overall good PR. The code is getting complicated enough that it's probably a good idea for us to start adding some tests...

ryan-lane commented 7 years ago

Thanks for the contribution btw :)

brandond commented 7 years ago

OK @ryan-lane I think I got everything you asked for. I also fixed the mock routes, since I had forgotten to look at them.

brandond commented 7 years ago

@ryan-lane anything else you need here?

ryan-lane commented 7 years ago

Sorry about the delay. I need to do some manual testing with this.

brandond commented 7 years ago

If it helps any, I've been running it on our GitLab CI box for the last week or so and it's been working great. Probably smaller scale than y'all are running it at though ;)

ryan-lane commented 7 years ago

I'm really sorry for the long wait on this. I'm going to test this properly over the weekend and I think based on a review of the code that it'll be mergeable without change. Thanks again for the code!

ryan-lane commented 7 years ago

Thanks for the contribution!

ryan-lane commented 7 years ago

released in tag 1.5.0