lyft / metadataproxy

A proxy for AWS's metadata service that gives out scoped IAM credentials from STS
Other
456 stars 69 forks source link

added support to lookup containers over the mesos http api #89

Closed mburger closed 5 years ago

mburger commented 5 years ago

that should resolve https://github.com/lyft/metadataproxy/issues/88

ryan-lane commented 5 years ago

Thanks for the PR! Just had a small amount of feedback.

mburger commented 5 years ago

thank you for the feedback :D i will update the PR with the needed fixes soonish

mburger commented 5 years ago

@ryan-lane can you take a look again if the pr is now fine from your side ?

ryan-lane commented 5 years ago

Looks good!

ryan-lane commented 5 years ago

Thanks for the PR!