search

lyft / metadataproxy

A proxy for AWS's metadata service that gives out scoped IAM credentials from STS
Other
456 stars 69 forks source link

Make IAM role expiration threshold 15 minutes + configurable #95

Closed byronwolfman closed 4 years ago

byronwolfman commented 4 years ago

Fixes https://github.com/lyft/metadataproxy/issues/94

Hey friends. The linked issue describes the behaviour we're hoping to see addressed by this PR. In short: metadataproxy caches credentials until they are 5 minutes from expiration; this PR would change that threshold to 15 minutes, and also make it configurable.

I realize changing a default value is not always desirable, but if that's the case, our org is mostly interested in making the expiry configurable, even if changing the default is not possible.

ryan-lane commented 4 years ago

Hey, thanks for the PR and the detailed issue! Merging in.