search

lyft / nuscenes-devkit

Devkit for the public 2019 Lyft Level 5 AV Dataset (fork of https://github.com/nutonomy/nuscenes-devkit)
Other
365 stars 103 forks source link

MapMask is broken #72

Open artyompal opened 4 years ago

artyompal commented 4 years ago

I'd like to report the following problems with MapMask:

  1. It uses foreground=255, but if you look to the map, you'll notice that white color means background.
  2. Function is_on_mask is broken because it ignores 3 channels of RGB picture. (Python complains about indexing). The fix would be to check if all channels are white or non-white, like: mask = np.all(this_mask[py[on_mask], px[on_mask]], axis=-1)
artyompal commented 4 years ago

Repro: mask_map.is_on_mask(10000, 10000)

Or: mask_map.is_on_mask(10000, 10000, dilation=1) (this results in another error).