search

lyft / presto-gateway

A load balancer / proxy / gateway for prestodb
Apache License 2.0
358 stars 156 forks source link

Updating Selector's Update and Delete Functionality #115

Closed jchoi614 closed 4 years ago

jchoi614 commented 4 years ago

Currently, selectors are updated and deleted solely based off their resourceGroupId. This functionality is not representative of the actual relationship between selectors and resource groups, which is many to one (there can be multiple selectors with the same resource group id). With this change, the current selector's json must also be specified in addition to the updated selector's json - if the current selector's json does not exist, a new selector is created.

Relevant PRs: https://github.com/lyft/presto-gateway/pull/114

hitejinder commented 4 years ago

/approve (👍)

looks good. One minor comment would be to add more logging but only if you have time.