search

lyft / presto-gateway

A load balancer / proxy / gateway for prestodb
Apache License 2.0
358 stars 156 forks source link

Add support for Trino #136

Closed amitds1997 closed 3 years ago

amitds1997 commented 3 years ago

Trino uses X-Trino headers instead of X-Presto headers. Gateway uses X-Presto-User and X-Presto-Source to determine the user and source of query. Gateway would continue to work, however, these important metrics would not get recorded, for any query coming from a Trino client.

Check for either X-Trino-User or X-Presto-User is done on each query request. Similar check is done for X-Presto-Source and X-Trino-Source. Client libraries can specify X-Trino-Routing-Group instead of X-Presto-Routing-Group, for uniformity.

Fixes #134.

endoplasmicR commented 3 years ago

/approve

amitds1997 commented 3 years ago

Gentle ping for review or merge @riteshvaryani @JamesRTaylor