lyft / presto-gateway

A load balancer / proxy / gateway for prestodb
Apache License 2.0
358 stars 156 forks source link

Activate queue based router as default & Consider backend with no worker as unhealthy #208

Open okayhooni opened 1 year ago

okayhooni commented 1 year ago

There were valuable updates on routing logic with PrestoQueueLengthRoutingTable routing manager and PrestoQueueLengthChecker observer, like below.

But, current codebase in this repository don't use both PrestoQueueLengthRoutingTable and PrestoQueueLengthChecker. And besides, there is no option to activate those useful features without code modification.

I think, there is no reason to maintain HaRoutingManager as default, because PrestoQueueLengthRoutingTable is derived from it. So, it makes sense to activate PrestoQueueLengthRoutingTable and PrestoQueueLengthChecker by default.

Plus, I add minor logic to consider cluster with no worker as unhealthy.