search

lyft / presto-gateway

A load balancer / proxy / gateway for prestodb
Apache License 2.0
358 stars 156 forks source link

QueryIdCachingProxyHandler.java extractQueryIdIfPresent logic error #59

Closed rongfengliang closed 5 years ago

rongfengliang commented 5 years ago

extractQueryIdIfPresent methed in QueryIdCachingProxyHandler.java get queryid may get error id when statement in different statu, this will cause query routing error like this 

/v1/statement/queued/20190823_150041_00020_bm7k5/xfe619af6efe0400296a6f29f80ce67ab/1

should do more check for path /v1/statement/..... if contains different statu

puneetjaiswal commented 5 years ago

Thanks @rongfengliang for reporting, would you have some cycles to send a PR for the fix?

rongfengliang commented 5 years ago

@puneetjaiswal ok, i hava fix it pr

puneetjaiswal commented 5 years ago

Thanks @rongfengliang for adding the fix. Can you please sign the CLA, then we can merge this.