lyft / presto-gateway

A load balancer / proxy / gateway for prestodb
Apache License 2.0
358 stars 156 forks source link

Update ehcache 2.7.4 -> 3.8.1 and activeJDBC 2.2 -> 2.3 #95

Closed OgrockiMatthew closed 4 years ago

OgrockiMatthew commented 4 years ago

Problem The current version of ehcache will cause memory leaks when queries are sent to the gateway as ehcache will never clear statistics objects it creates about the queries.

There is no way to fix this in the current settings because activeJDBC locks statistis=true

Solution This solution will update ehcache to use a new version of ehcache and activeJDBC that does not have this issue. This also requires a change in the ehcache configuration file.

Testing: We have made the following change in our local version of presto-gateway and have been running it in our production environment for 2 weeks without any issues and heap size has not increased.

Screen Shot 2020-02-18 at 5 31 09 PM

Issue to track this: 94