search

lyft / scissors

✂ Android image cropping library
https://eng.lyft.com/scissors-an-image-cropping-library-for-android-a56369154a19
Apache License 2.0
1.84k stars 236 forks source link

Image does not load + selecting an image loop #12

Closed rohanmahale closed 3 years ago

rohanmahale commented 8 years ago

I tested my app on a Sony Ericsson Xperia S. It is using scissors to select images to crop before adding them. I have used the selection as shown in the sample app.

cropView.extensions().pickUsing (this,REQ_CODE)

This works perfectly well on other devices that I have tested it on - Xiaomi, Samsung s3, Galaxy S4. However on the Sony Ericsson Xperia S, when I select an image to crop, many times the cropView does not load the image instead the selection prompt pops up again. Is this related to the other load issue?

eveliotc commented 8 years ago

@rohanmahale first part (image not loading) might be related to #6 so please try snapshot and let me know if that fixes that part, as per

the selection prompt pops up again

It might be due multiple pickUsing calls, can you please confirm pickUsing is only called once?

rohanmahale commented 8 years ago

@eveliotc pickUsing is called only once.

rohanmahale commented 8 years ago

The load issue is fixed. The issue of the recurring popup still exists. I used a workaround and stopped using pickUsing(). I passed the file path(converting the Uri) via an extra to my cropping activity and directly load this using load(). Should I close this?

dschaller commented 3 years ago

Thank you for you contribution to this repository.

Closing this contribution as this repository is being archived.