Crop View only configurable via XML

[rharter]

The current CropViewConfig mechanism really cleans up attribute parsing, but also greatly limits the view since it can only be configured via xml. Want to programmatically create a view with non-default options? No, thank you.

I think we need standard getters/setters on the CropView object so that we can not only programmatically configure the view, but also alter the view at runtime (like allowing the user to choose from standard aspect ratios.

[eveliotc]

We could offer a config API to return a builder of CropViewConfig such as:

cropView.config()
  .withViewportHeightRatio(Ratio.16_9)
  .withViewportColor(Color.BLACK)
  .apply()

Apply would create a new CropViewConfig based off current configuration and set the view and manager to new configuration

[rharter]

What's the benefit of doing it this non-standard way? It seems like it's more trouble than it's worth, to me.

As an example of the kind of problem this introduces, it means that we can't use standard animations on the view. For instance, in my current production use case, I have buttons that allow the user to choose from 5 standard aspect ratios, 1:1, 5:4, native, 3:2 and 16:9. When the user taps a button, it animates the viewport to the desired ratio. Adding this config api makes that quite difficult to do.

I think the best approach would be to use standard properties on the view and get rid of the config object all together.

[eveliotc]

Benefit would be having a immutable configuration and a similar API to extensions, it could be easily implemented at this point as it is how configuration from XML works, animations could be run on config changes, but I do agree that's not a common approach vs. simply having setters

[rharter]

What do you mean by "animations could be run on config changes"? I'm not sure how the fits the provided use case. The problem is that the configuration is, by nature, not immutable. I see no reason the developer can't change things like the viewport ratio at runtime, for instance, when the user selects a different aspect ratio from a button in the UI.

[rharter]

Here's an example of the type of UX I'm talking about that an immutable config object doesn't support.

[dschaller]

Thank you for you contribution to this repository.

Closing this contribution as this repository is being archived.