search

lyft / scissors

✂ Android image cropping library
https://eng.lyft.com/scissors-an-image-cropping-library-for-android-a56369154a19
Apache License 2.0
1.84k stars 235 forks source link

GlideBitmapLoader.createUsing uses cropView's size while it might not be laid out #77

Closed ldiqual closed 2 years ago

ldiqual commented 7 years ago

The following code:

cropView
  .extensions()
  .using(GlideBitmapLoader.createUsing(cropView))
  .load(uri)

won't work if cropView is not yet laid out – even with #16 in – because GlideBitmapLoader.createUsing directly extracts cropView.getHeight() and cropView.getWidth(): https://github.com/lyft/scissors/blob/master/scissors/src/main/java/com/lyft/android/scissors/GlideBitmapLoader.java#L57-L61. At this point, cropView's dimension is 0:0.

I worked around this by adding a 100ms delay, but that's obviously hacky.

mikecutalo commented 2 years ago

Thank you for you contribution to this repository.

Closing this Issue as this repository is being archived.