search

lyhistory / Peter-s-Tool

GNU General Public License v3.0
7 stars 1 forks source link

UI improvements #2

Closed lyhistory closed 5 years ago

lyhistory commented 5 years ago

@farrahfazirah for the discussion, I copy over some of the comments here

lyhistory commented 5 years ago

latest please have a review to confirm whether this version meet the functional requirement, I know there are a lot work to do to improve the look and feel, for example: 1)reset the ticket list to empty 2)too painful to scroll down 100 dropdownlist to find the desired location, need to customize the combobox to add a search filter. 3) the datetime picker is too basic, not ease to use 4) for rendering datepicker ui component based on the XML, for now I check the id against hardcoded 'time' to decide whether to render it as a Jtextfied or a datetimepicker, this will cause issue when the xml variant with differenet id or multiple datetime attributes etc

lyhistory commented 5 years ago

2

  1. I have added in a "RESET" button as a suggestion beside the ticket list field
  2. I have a question regarding this:
    • Is each individual Token ID a dropdown? I'm thinking that you could do something like this https://codepen.io/kaleem78/pen/YjLqXQ where all the Token IDs are in one dropdown field and you could input text on the dropdown field to search for a particular Token ID.
    • However, in my UI, in case you still want to add in a search field, I have added in a UI suggestion.
  3. I did not add this in the UI above: Can we have a DATE and TIME attribute? There is only TIME attribute. I believe we should add in a DATE attribute to make the date time picker easy to use.
lyhistory commented 5 years ago

@farrahfazirah sorry for my limited English, I need to improve my English:), let me try to make some clarification: first of all, please make sure you get the latest code from branch feature/desktop-magiclink from your screenshot I think the your code is not synced the latest, the time field on the upper pane supposed to be a datetime picker.

  1. the reset button looks fine

  2. 1)each token id is a dropdown, that's correct, if I'm not mistaking the requirement, when you generate the "Magic Link", it supposed to be a N:1 mapping, means a list of tokenID generates one Magic Link (as showing in my screenshot above) 2) I don't think we need a 'search box' for the tokenid, I'm talking about the the location(country/city) dropdownlist, and the 'search field' effect I'm thinking of is exactly the same with the one you suggest https://codepen.io/kaleem78/pen/YjLqXQ , I just need to figure it out how to implement it in jswing, actually I'm more familiar with HTML/JS :)

  3. this date picker I'll try to enhance it first, I don't think we need two separate attributes, please note that there are two datetimepicker: Time attributes on the upper pane, and expireTime on the lower pane, one more reason I don't want to separate date and time is I have to add listener to the datetimePicker, it will be more complicated if separate them

farrahfazirah commented 5 years ago

I have spoken to Weiwu regarding the UI issue. The current UI has to be scrapped.

The new UI proposed is below:

contractmanager contractmanager2 contractmanager3

lyhistory commented 5 years ago

some questions:

  1. are we going to use JSWING GUI or Web UI, have you discussed it? and I found some embedded webkit library which enable us to use HTML+CSS with JSwing, but unfortunate, some are not free, for example: https://www.teamdev.com/jxbrowser#licensing-pricing you can take a look at this sample for better understanding: https://dzone.com/articles/htmlcssjavascript-gui-java-0

  2. can you give me a complete flow with the new UI, because from this three screenshots I feel confused: a) missing Panel for the xml attributes (the upper panel from my screenshot) b) what does the tabs represent? c) create new xml ? does it mean the same as upload xml? d) missing connection: tokenID generation and magic link generation e) the owner column, from the requirement, I don't see owner information in the magic link, not sure why we need owner here, information of magicLink: MagicLink: https://app.awallet.io/base64(Message|Signature) priceInWei 32 bytes (4 bytes MicroEth) expiry 32 bytes (4 bytes unsigned) contractAddress 20 bytes tokenIDs 32bytes * count

f) from the UI I don't know which are textfield , which are dropdown,

could you please provide the new design by making static html pages with dummy data?

miang719 commented 5 years ago

@farrahfazirah take a look

SmartLayer commented 5 years ago

This is closed as we fixed the direction