Closed isotherm closed 2 years ago
Note: These branches depend on each other. Look at PR #7 & PR #8 first.
@isotherm After reviewing this PR I noticed that the earlier PRs are already included into this one. Do you mind if I ignore them and we discuss and merge this? The changes are small enough to be easily reviewed together.
No trouble - I wasn't sure if you would like to deal with them separately or not.
@isotherm Looks good to me. Can you verify creating and updating the alphaword files with some unicode symbols supported by Neo, such as accents or circumflex?
After the check I'll merge it.
To summarize the chatter above, creating new files with unicode symbols works with this change, but wasn't working before (UTF-8 or a translation thereof was being sent to the Neo).
@isotherm I remember that it worked at some point. Thank you for fixing this. The text handling needs a better test suite.
@isotherm I'm going to release a new version some time next week.
@isotherm Released 0.3.2 with your changes. Thanks again!
The existing behavior (don't check if applet exists) allows multiple applets of the same id to exist, which causes odd problems with the device's OS, and also neotools (referring to files, etc).
I couldn't think of a reason to retain the previous behavior, but if it is needed, maybe the option should be called "skip" or similar?