search

lykmapipo / kue-scheduler

A job scheduler utility for kue, backed by redis and built for node.js
246 stars 47 forks source link

node_redis warning when switched from kue #57

Closed Deadly0 closed 7 years ago

Deadly0 commented 7 years ago

This warning appears after installing kue-scheduler node_redis: Deprecated: The HDEL command contains a "undefined" argument. This is converted to a "undefined" string now and will return an error from v.3.0 on. Please handle this in your code to make sure everything works as you intended it to.

lykmapipo commented 7 years ago

Fixed in v0.6.3.

Roost commented 7 years ago

@lykmapipo I'm still seeing this error while running v0.6.3. Any ideas why?

rfranczyk commented 7 years ago

I am also seeing this error on 0.6.3

mzilot commented 7 years ago

It seems not fixed yet!

hfreire commented 7 years ago

@lykmapipo is it possible that the culprit might be in kue-unique dependency?

gmcnaught commented 7 years ago

Yes, very likely the issue is related to kue-unique here: https://github.com/lykmapipo/kue-unique/blob/master/index.js#L124

So what I don't have a full view here is what steps you took to cause this? It seems like we can just wrap this with an if (key !== undefined) { } and call it done?

On Wed, Nov 30, 2016 at 2:02 PM, Hugo Freire notifications@github.com wrote:

@lykmapipo https://github.com/lykmapipo is it possible that the culprit might be in kue-unique dependency?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/lykmapipo/kue-scheduler/issues/57#issuecomment-263962905, or mute the thread https://github.com/notifications/unsubscribe-auth/ABTsfw1lvGggmhrKUJ8WCqqc1NVA1BpBks5rDcg2gaJpZM4KSGHd .

IvanMMM commented 7 years ago

Same for me. 0.6.5

mmarshak commented 7 years ago

I am getting also this error when I try to delete the job. Any update on this?

IvanMMM commented 7 years ago

There is a pull request in unique repo. Use it.

mmarshak commented 7 years ago

@IvanMMM do you mean request - #25. It seems it is merge almost a year ago?

IvanMMM commented 7 years ago

@mmarshak, nope. I mean https://github.com/lykmapipo/kue-unique/pull/7

mmarshak commented 7 years ago

Thanks, this fix works. However I deploy my server in AWS and they run pm install, which will override the changes. I wish it was part of the official release.

adin234 commented 7 years ago

@mmarshak you can update your package.json to use the fork.

https://docs.npmjs.com/files/package.json#git-urls-as-dependencies

"kue-unique" : "adin234/kue-unique#e6f045b092"
mmarshak commented 7 years ago

@adin234 thank you for the reference to the fork, however my npm dependency is of kue-scheduler, and not direct dependency of kue-unique. Therefore I will need also to fork kue-scheduler to in order to change its package.json to point to your fork.

NSCoder commented 7 years ago

I'm experiencing the same issue, would be possible to reopen this issue until lykmapipo/kue-unique#7 is merged and a new version of kue-scheduler is released?