search

lykmapipo / kue-scheduler

A job scheduler utility for kue, backed by redis and built for node.js
246 stars 47 forks source link

Redis filter #8

Closed aigoncharov closed 9 years ago

aigoncharov commented 9 years ago

Tests added unexpected behavior of computeNextRunTime fixed

lykmapipo commented 9 years ago

@keenondrums

May you please create an issue for unexpected behavior of computeNextRunTime it will help us to know what was the problem.

Thanks.

lykmapipo commented 9 years ago

@keenondrums

I have been working on this too. I will merge it soon.

I appreciate.

lykmapipo commented 9 years ago

@keenondrums

I think you getting that because all job expiry key are using kue prefix:scheduler:uuid pattern and you are publishing q:message and expect a worker to perform the job.

Well am on it, hope i will resolve with your pull request and merge.

aigoncharov commented 9 years ago

I think you getting that because all job expiry key are using kue prefix:scheduler:uuid pattern and you are publishing q:message and expect a worker to perform the job.

I thinnk it's the issue. In fact it's nearly impossible to get an incorrect message with a "q" prefix. But in case if we did it's much better to fall gracefully with a schedule error, not with some unhandled exception.

lykmapipo commented 9 years ago

@keenondrums

I thinnk it's the issue. In fact it's nearly impossible to get an incorrect message with a "q" prefix. But in case if we did it's much better to fall gracefully with a schedule error, not with some unhandled exception.

I have add scheduler unknown job expiry key event which emit unknown key on kue instance. I see that is better than propagation thrown error all over.