lykmapipo / mongoose-gridfs

mongoose gridfs on top of new gridfs api
MIT License
91 stars 39 forks source link

Add find prototype #74

Closed b00tsy closed 2 years ago

b00tsy commented 2 years ago

Thought others might need this, too.

lykmapipo commented 2 years ago

@b00tsy Looks good. Anyhow we can use a different name cause GridFSBucket.html#find already exists and we are overriding it.

Suggestions:

GridFSBucket.prototype.findAll = function findAll(optns, done) { ... }
b00tsy commented 2 years ago

@lykmapipo cool, didn’t know one could use the GridFSBucket.html#find https://mongodb.github.io/node-mongodb-native/4.1/classes/GridFSBucket.html#find directly. Looks to me we don’t need my prototype at all, cause we can call it directly? Works for me...

On 16. Nov 2021, at 06:19, lally elias @.***> wrote:

@b00tsy https://github.com/b00tsy Looks good. Anyhow we can use a different name cause GridFSBucket.html#find https://mongodb.github.io/node-mongodb-native/4.1/classes/GridFSBucket.html#find already exists and we are overriding it.

Suggestions:

GridFSBucket.prototype.findAll = function findAll(optns, done) { ... } — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lykmapipo/mongoose-gridfs/pull/74#issuecomment-969869776, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACCYSBOZIJBGPLFXSXP3PLUMHSWPANCNFSM5ICSTDOQ.