lykmapipo / sails-hook-validation

Custom validation error messages for sails model with i18n support
104 stars 29 forks source link

Problem with npm 3 #25

Closed bogdan-r closed 8 years ago

bogdan-r commented 8 years ago

Hello.

When I try run sails app, I get next error:

error: Error: Cannot find module 'sails/node_modules/waterline/lib/waterline/query/deferred'
    at Function.Module._resolveFilename (module.js:336:15)
    at Function.Module._load (module.js:286:25)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Users/user/projects/happsy/happsyphoto/node_modules/sails-hook-validation/lib/create.js:5:16)
    at Module._compile (module.js:434:26)
    at Object.Module._extensions..js (module.js:452:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Users/user/projects/happsy/happsyphoto/node_modules/sails-hook-validation/index.js:10:14)
    at Module._compile (module.js:434:26)
    at Object.Module._extensions..js (module.js:452:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)

In npm 3 modules have flat structure and waterline module installed outside sails folder. I think you should include waterline module in your package.json like dependence. In advance, thanks. P.S. sorry for my bad english.

lykmapipo commented 8 years ago

@bogdan-r

I will appreciate a pull request to fix this.

Thanks

lykmapipo commented 8 years ago

@bogdan-r

It will appreciate reopen of this issue with a pull request.

ablipan commented 8 years ago

@lykmapipo This issue is not fixed yet.

lykmapipo commented 8 years ago

@ablipan

I will appreciate pull request to fix this issue. Else may you please provide me with the node and npm version so that i can work with it. I will appreciate if its stable npm version

ablipan commented 8 years ago

npm : no3.5.0 node: v4.2.1 Have this issue with the root user. But do not know why, after switching to the normal user, the issue is disappeared.

andrewoh531 commented 8 years ago

+1

npm: v3.3.12 node: v4.2.2

lykmapipo commented 8 years ago

@aohx075

Will be fixed on next version.

semy commented 8 years ago

status? can't us it :-(

lykmapipo commented 8 years ago

Hello,

I managed to merge pull requests but all specs failed. Am now working to fix them. Soon it will be out.

Sorry.