lykoss / lykos

Werewolf, the popular detective/social party game (a theme of Mafia)
https://werewolf.chat
Other
127 stars 63 forks source link

Wild child doesn't turn when idol idles out #437

Closed an-empty-string closed 2 years ago

an-empty-string commented 4 years ago

In a game on 19th April 2020 starting at 23:55 UTC, I was wild child and idolized noomy:

23:55 -- lykos: You are a wild child. You must pick an idol with "choose <nick>", and you will become a wolf if your idol dies. You are a villager as long as your idol is alive.
23:55 -- lykos: Players: erry, aismallard, Quokka, nyuszika7h, neemos, Mariven, hexa-, Tux[Qyou], Iciloo, RyanKnack, werekitten, and noomy
23:55 <empty_string> choose noomy
23:55 -- lykos: You have picked noomy to be your idol for this game.

Then, at midnight 20th April:

00:00 <@lykos> noomy didn't get out of bed for a very long time and has been found dead. The survivors bury the wolf's body.

However, I didn't get any messages from lykos about turning, and didn't get any messages in wolfchat. I think this is a bug; according to wiki, "once their idol dies for any reason, they become a wolf" and this would seem to include idling out.

jacob1 commented 4 years ago

Seems intentional, but I'm unsure why.

https://github.com/lykoss/lykos/commit/e163fec80ad7cbfa8980c819921473376d1b7ff5

Clone turns when the target idles out, so I don't see why wild child shouldn't either

MishaCatskill commented 4 years ago

This should definitely behave like clone and not like lovers.

skizzerz commented 4 years ago

Clone is wrong here, not wild child. Probably clone shouldn't turn if the target idles out, but should be able to pick a new target instead. Someone idling out is not supposed to trigger anything on death.

MishaCatskill commented 4 years ago

I'd be fine with both clone and wild child getting to retarget if their original selection idles out.