ninja generator never closes output files

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Install pypy.
2. Run GYP_GENERATORS=ninja pypy build/gyp_chromium in chromium tree.

What is the expected output? What do you see instead?

Expect to have successfully generated ninja files. Instead we see

  File "app_main.py", line 72, in run_toplevel
  File "/Users/jjgod/work/chromium/src/build/gyp_chromium", line 160, in <module>
  File "/Users/jjgod/work/chromium/src/tools/gyp/pylib/gyp/__init__.py", line 540, in main
  File "/Users/jjgod/work/chromium/src/tools/gyp/pylib/gyp/__init__.py", line 525, in gyp_main
  File "/Users/jjgod/work/chromium/src/tools/gyp/pylib/gyp/generator/ninja.py", line 2001, in GenerateOutput
  File "/Users/jjgod/work/chromium/src/tools/gyp/pylib/gyp/generator/ninja.py", line 1928, in GenerateOutputForConfig
  File "/Users/jjgod/work/chromium/src/tools/gyp/pylib/gyp/generator/ninja.py", line 1369, in OpenOutput
IOError: [Errno 24] Too many open files: 
'/Users/jjgod/work/chromium/src/out/Release/obj/<some file name>.ninja'

What version of the product are you using? On what operating system?
gyp from chromium master, pypy 2.1. Mac OS X 10.8.4.

Attached a trivial patch to fix this.

Original issue reported on code.google.com by jia...@opera.com on 21 Aug 2013 at 8:44

Attachments:

• 0001-Closes-ninja-output-files-when-done.patch

[GoogleCodeExporter]

Submitted patch as https://codereview.chromium.org/22794014/

Original comment by jia...@opera.com on 21 Aug 2013 at 8:47

[GoogleCodeExporter]

I think I fixed that a while ago.

Original comment by thakis@chromium.org on 3 Nov 2013 at 2:19

• Changed state: Fixed