search

lyn-wow / LynUI

World of Warcraft User Interface for Legion
http://www.wowinterface.com/downloads/info24059-LynUI.html
4 stars 0 forks source link

Performance Issues #7

Closed muffz closed 8 years ago

muffz commented 8 years ago

Hi, good job doing this UI.

I realized LynChat has some issue with its performance, it uses a "huge" amount of CPU time (sometimes up to ~15%). Even without doing anything the use is really "high" (0.2% to 1%) in comparison of my other addons.

The Clean up Bags function works really bad, no problem with eg. FreeUI bags sort function. I got freezes of about 1 sec everytime my use it with your compilation.

mtthsw commented 8 years ago

I'll look into that chat thing, thanks.

For the bag issue, go here .

muffz commented 8 years ago

Did you encounter the same issue with the bags? Also creating or moving items causing stutter...

mtthsw commented 8 years ago

Not really, tbh. I didn't get any freezes or high cpu usages at all.

Looking through chat if I can optimize something there.

muffz commented 8 years ago

That's interesting. I also get huge fps drops if I shift hover items for comparison. So i think its a problem on my end since you also don't have any problems with the bags at all.

mtthsw commented 8 years ago

What addons are you using next to my UI?

muffz commented 8 years ago

The problem is that if I load only litebag and sort my inventory it also stutter. Default bags, no problem. LynTooltip also uses also ~10% if i compare items with shift hover. Only Lyn and LynTooltip loaded. Already cleaned WTF folder. CPU is i5 2500k so its not that bad. wowscrnshot_100116_162243 spamming clean up bag to show the issue wowscrnshot_100116_162635

mtthsw commented 8 years ago

2500k is quite ... old.

The thing is, I can't do anything about the Bag, it isn't made by me. If you have problems with CPU usage of Litebag, go to the Curse site.

The highups of Tooltip is because you are spamming the comparison, as you said, for testing purpose. That is normal, because it creates two new tooltips everytime including the skinning.

I'll run some CPU tests now.

mtthsw commented 8 years ago

btw, bear this in mind if you are judging usage of addons:

The reason CPU monitoring isn't on by default is because the act of monitoring how much work your addons are doing causes a bit more work that will slow you down even more unless you're on a high end system or have few addons. You should only have CPU monitoring enabled when you're testing.

muffz commented 8 years ago

I know you can't do anything about the maps, maybe you just had a idea. I only spammed bag sort. The tooltip was just normal usage, no spamming. I got also fps decrease on normal usage without having CPU monitoring enabled, just shift+hover.

mtthsw commented 8 years ago

I got slight higher CPU usage while shift+hover a lot items ... but no FPS drops. Except kicking out whole functions I can't do anything for it.

muffz commented 8 years ago

So I did a WoW Repair since this all seems very wierd.

I think you can close the issue. I found out that Stat Weight Score causing the stutter, because it's doing math on every tooltip update and this multiplied by 3 if I compared items. I suppose it's not written for efficiency.

LynChat seems good now. Tooltip seems to drain only performance on compare, could not find the issue until now. I don't understand the LiteBag issue since I don't see any impact on the CPU utilization. I think it must be a code issue since FreeUI's bags work with zero problems/lags.

mtthsw commented 8 years ago

Hm, okay.