Closed niwinz closed 9 years ago
Thank you very much for the patch. A couple of things:
Path
, etc. requires JDK7+, but ClojureScript only requires JDK6+ IIRC. Could you explain what the issue is that your (2) is addressing?Hi Chas!
Ok, I've removed not related commits to #60 issue and I will send them as separate PR.
The previos implementation has two drawbacks:
Appending file:
is a proper behavior for URI but not for filesystem paths. For it, nio Path fits much better, because it handles the fs paths much correctly that URI.
In my opinion, we should keep Path, but if your insist on have support for JDK6, I'll try to reimplement the second commit using URI with explicit checking the "file:" prefix, for removing it.
In any case, each commit has a little explication about it changes (on the body of the commit).
Yes, let's please keep JDK6 compat. I don't use it, but others might. Tracking the compatibility targets of Clojure and ClojureScript is the right thing to do.
Thanks for the tidying! Looking forward to merging.
+1
This fix is critical for lein cljx auto
to be useful (e.g. with lein cljsbuild auto
).
I've merged this into my fork. Does the job.
(BTW, I don't think JDK6 is still relevant)
Replaced by new pr, already linked ;)
Hi.
This pr includes: