Fix #61 - Remove double output when cljx auto task is executed.

lynaghk / cljx

Write a portable codebase targeting Clojure/ClojureScript

Other

398 stars 34 forks source link

Fix #61 - Remove double output when cljx auto task is executed. #67

Closed niwinz closed 9 years ago

niwinz commented 9 years ago

The bug is mainly caused by wrong relativize behavior when a file does not corresponds to the same rootpath, appending unexpected and/or wrong handled file:// prefix.

This fix, adds additional step that filters the incoming file list by corresponding rootpath, allowing to relativize working correctly and add additionally strip the file:// prefix from result of relativize if it appears unexpectly.

NOTE: replaces #62, now compatible with jdk6 and in one unique commit.

Deraen commented 9 years ago

:+1:

This also fixes using relative source-paths, like "../shared/src/cljx".

cemerick commented 9 years ago

Thank you for your work in this @niwibe, but the proposed changes were quite large for the problem at hand. I believe I've fixed this on master, available in [org.clojars.cemerick/cljx "0.6.0-SNAPSHOT"] until the final 0.6.0 release is cut.

@Deraen The change I just made does seem to work well with relative source paths like you suggest…however, I wouldn't rely on such things to work. Projects should be contained within a particular directory; I'd suggest using symlinks to bring in other directories if you absolutely have to, rather than using relative paths.