lynckia / licode

Open Source Communication Provider based on WebRTC and Cloud technologies
http://lynckia.com/licode
MIT License
3.1k stars 1.01k forks source link

remove wget dependency from Dockerfile #851

Open menelike opened 7 years ago

menelike commented 7 years ago

https://github.com/lynckia/licode/blob/27dc114a7c38eaa88ba775b9f8b399bd5d0aae0c/extras/docker/Dockerfile#L8

uses wget but actually does not need it. If you remove that, nvm will fail to install node.

https://github.com/lynckia/licode/blob/27dc114a7c38eaa88ba775b9f8b399bd5d0aae0c/scripts/installUbuntuDeps.sh#L65-L73

already installs curl, to get rid of wget, a reordering like this could work:

  sudo apt-get update -y
  sudo apt-get install -qq python-software-properties -y
  sudo apt-get install -qq software-properties-common -y
  sudo add-apt-repository ppa:ubuntu-toolchain-r/test -y
  sudo apt-get update -y
  sudo apt-get install -qq git make gcc-5 g++-5 libssl-dev cmake libglib2.0-dev pkg-config libboost-regex-dev libboost-thread-dev libboost-system-dev liblog4cxx10-dev rabbitmq-server mongodb curl libboost-test-dev -y
  sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-5 60 --slave /usr/bin/g++ g++ /usr/bin/g++-5

  install_nvm_node
  nvm use
  npm install -g node-gyp

  sudo chown -R `whoami` ~/.npm ~/tmp/ || true
jcague commented 7 years ago

thanks for the heads up, we'll remove it in future releases