Tags styling needs to work even when there's an <a> tag around it

[siruguri]

If you add an a tag to allow tags on the search result page to be hyperlinked, it turns blue and becomes hard to read.

[sunnyrjuneja]

What's the file and line number?

[siruguri]

Sorry - app/views/search/index.html.haml, line 57

On Tue, Jul 8, 2014 at 2:40 PM, Sunny Juneja notifications@github.com wrote:

What's the file and line number?

— Reply to this email directly or view it on GitHub https://github.com/lynco/GetThroughThis/issues/5#issuecomment-48403011.

[siruguri]

                    %span{class: "label #{highlight_label_with_query(

tag.name, session[:search_query])}"} \

{link_to tag.name, tag}

On Tue, Jul 8, 2014 at 2:42 PM, Sameer Siruguri siruguri@gmail.com wrote:

Sorry - app/views/search/index.html.haml, line 57

On Tue, Jul 8, 2014 at 2:40 PM, Sunny Juneja notifications@github.com wrote:

What's the file and line number?

— Reply to this email directly or view it on GitHub https://github.com/lynco/GetThroughThis/issues/5#issuecomment-48403011.

[sunnyrjuneja]

Great, I'll take a look and add this to the fixes.

On Tue, Jul 8, 2014 at 2:43 PM, Sameer S notifications@github.com wrote:

%span{class: "label #{highlight_label_with_query( tag.name, session[:search_query])}"} \

{link_to tag.name, tag}

On Tue, Jul 8, 2014 at 2:42 PM, Sameer Siruguri siruguri@gmail.com wrote:

Sorry - app/views/search/index.html.haml, line 57

On Tue, Jul 8, 2014 at 2:40 PM, Sunny Juneja notifications@github.com wrote:

What's the file and line number?

— Reply to this email directly or view it on GitHub https://github.com/lynco/GetThroughThis/issues/5#issuecomment-48403011.

— Reply to this email directly or view it on GitHub https://github.com/lynco/GetThroughThis/issues/5#issuecomment-48403313.

[sunnyrjuneja]

I'm unable to reproduce this. Are you sure about the filename and line number? What browser are you using?

In an old commit this is line 57.

https://github.com/lynco/GetThroughThis/blob/3e83566c5ffa2ac4a2a8e1cbcd1a44c8eb640e59/app/views/search/index.html.haml#L56-58

The only other commit is https://github.com/lynco/GetThroughThis/blob/c9d481bc34f074b92b0157ad117356a46e1bd682/app/views/search/index.html.haml

which doesn't have a line number 57.

[siruguri]

I think I might have fixed it already with this in line 53, in https://github.com/lynco/GetThroughThis/blob/c9d481bc34f074b92b0157ad117356a46e1bd682/app/views/search/index.html.haml:

%span{class: "label filter-label"}

closing.