lyndonlim27 / pe

0 stars 0 forks source link

Unable to edit Person's ID #3

Open lyndonlim27 opened 1 year ago

lyndonlim27 commented 1 year ago

It was mentioned in the UG that editing a person's information is useful as a person may key in their details wrongly. For example their name, as shown below

image.png

However, there is a high chance that a patient may also key in their id wrongly, but the edit feature does not allow for the ID to be edited.

image.png

Severity is medium as this is a feature flaw that causes occasional inconvenience to some users but they can still continue to use the product.

nus-pe-bot commented 1 year ago

Team's Response

We determine uniqueness of persons by their ID. Hence, we restrict the changing of IDs to prevent any possibility of duplicate persons. In fact, the error message in the app specifies that ID cannot be changed. This is therefore well defined feature and expected behaviour.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Although the app works as intended but as mentioned, users may key in their details wrongly such as name and id. Being able to only edit certain details defeats the purpose of the edit command as users have to delete that entry and add a new entry.

Working as intended does not justify the feature flaw of the product. Severity is medium as this is a feature flaw that causes occasional inconvenience to some users but they can still continue to use the product.

The team also said that

Hence, we restrict the changing of IDs to prevent any possibility of duplicate persons

But this is the team's responsibility to handle invalid/duplicate inputs.

Also the team accepted my feature flaw bug where editing of priority is not allowed. Therefore this feature flaw should be accepted as well.