lyndonlim27 / pe

0 stars 0 forks source link

Editing Json file #5

Open lyndonlim27 opened 1 year ago

lyndonlim27 commented 1 year ago

Editing the json file allows patients to have the same id.

Suggestion: It would be good to have a validity checker whenever the app is launched.

image.png

nus-pe-script commented 1 year ago

Team's Response

This is undefined behaviour which occurs when json file is directly edited, which is not supported in the current version.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

App cannot be launched after editing the id of a patient to that of another patient

image.png

image.png

after editing the id of a patient to that of another patient, the application can no longer be launched. This problem is fixed after changing the id to one that does not currently exist.


[original: nus-cs2103-AY2223S2/pe-interim#3267] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We have not provided for editing of the data file directly to be a feature in this milestone. Modifying the data file directly when neither the UG nor DG provides for such functionality can be seen as extreme behaviour seeking to corrupt the app data. This is a less important use case than developing other core functionality in the app. Potential future improvement.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** As shown in the screenshot below, there is no warning in UG that states the json file cannot be edited. This should still be in scope as many teams including mine have handled invalid json file that was edited directly. ![image.png](https://raw.githubusercontent.com/lyndonlim27/pe/main/files/7e61cbd3-4405-4b35-b1ae-3148319caf47.png) The team mentioned potential future improvement but this is not mentioned in the DG planned enhancement section ![image.png](https://raw.githubusercontent.com/lyndonlim27/pe/main/files/2d956076-ff29-481a-9be7-55213f519cc4.png)