search

lynndylanhurley / devise_token_auth

Token based authentication for Rails JSON APIs. Designed to work with jToker and ng-token-auth.
Do What The F*ck You Want To Public License
3.52k stars 1.14k forks source link

Faker safe_email -> email #1607

Closed hatsu38 closed 8 months ago

hatsu38 commented 9 months ago

NOTE: Faker::Internet.safe_email is deprecated; use email instead. It will be removed on or after 2023-10. FYI: https://github.com/faker-ruby/faker/blob/56a96cc3d54b9249f8062ebf1779deabc4a282f3/lib/faker/default/internet.rb#L87

            deprecate :safe_email, :email, 2023, 10

The safe_email method is deprecated. The email method is safe by default. https://github.com/faker-ruby/faker/pull/2733

This is a local test result.

スクリーンショット 2023-09-13 19 07 35
MaicolBen commented 8 months ago

This broke some specs, I fixed it here https://github.com/lynndylanhurley/devise_token_auth/pull/1613