search

lynndylanhurley / ng-token-auth

Token based authentication module for angular.js.
Do What The F*ck You Want To Public License
1.79k stars 234 forks source link

Remove CoffeeScript Transpiling? #202

Open booleanbetrayal opened 9 years ago

booleanbetrayal commented 9 years ago

Just went down a rabbit-hole trying to update NPM dependencies while getting the CoffeeScript transpiling / Karma setup to work. Ultimately punted. Given that CoffeeScript is losing support in favor of other abstractions, and given that the transpiled code is often hard to read, I'm thinking of eliminating this dependency altogether. Any objections?

booleanbetrayal commented 9 years ago

@lynndylanhurley ^

lynndylanhurley commented 9 years ago

How would you feel about using ES6 / babel?

booleanbetrayal commented 9 years ago

I've left client-side ES6 alone due to the lack of any real debugging symbols support. As in, debugging transpiled code is painful, and sourcemaps don't fill all the gaps. I THINK I'd favor ES5 at this point.

lynndylanhurley commented 9 years ago

After reviewing the code again, I think ES5 is probably ok for this project.

lynndylanhurley commented 9 years ago

@booleanbetrayal - take a look a the j-toker source. It's all ES5 and it can be easily adapted to work with angular. This might be a good place to start.