search

lynndylanhurley / redux-auth

Complete token authentication system for react + redux that supports isomorphic rendering.
Do What The F*ck You Want To Public License
2.13k stars 258 forks source link

Don't depend on ImmutableJS #62

Open wmertens opened 8 years ago

wmertens commented 8 years ago

Not everyone uses ImmutableJS, and requiring it adds a 57KB minified chunk of code to the initial download.

There is so little data in the auth reducer that ImmutableJS only adds overhead, with very little benefit. Would you consider dropping the dependency? You can use Object.assign or simply the ... spread operator for merging state into a new object.

lynndylanhurley commented 8 years ago

I'll accept a PR for this.

wmertens commented 8 years ago

FYI I'm working on this in https://github.com/wmertens/redux-auth/tree/no-immutable - almost there.

lynndylanhurley commented 8 years ago

@wmertens - I appreciate the help, thanks so much.

FullStackForger commented 8 years ago

@wmertens good luck. Looking to your PR too.

wmertens commented 8 years ago

I forgot about this 🙂 no time right now, anyone 'ant to take up where I left off?

On Wed, Sep 7, 2016, 6:52 PM IndieForger notifications@github.com wrote:

@wmertens https://github.com/wmertens good luck. Looking to your PR too.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lynndylanhurley/redux-auth/issues/62#issuecomment-245345817, or mute the thread https://github.com/notifications/unsubscribe-auth/AADWlhU6F0W3emMpyBodktWrV0e_Upwaks5qnuvXgaJpZM4I5tbL .

wmertens commented 7 years ago

Hi Karel,

I never got around to finishing it, iirc there were some more complex Immutable API calls that had to be changed, those are still in there.

On Sat, Mar 18, 2017, 1:43 PM Karel Frajtak notifications@github.com wrote:

@wmertens https://github.com/wmertens good job! I pulled your repo. However the issue is still there in the minified them file (in my case default-theme.js).

@lynndylanhurley https://github.com/lynndylanhurley can you push the unminified files into repo? Or are they available elsewhere?

Thanks, Karel

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lynndylanhurley/redux-auth/issues/62#issuecomment-287543791, or mute the thread https://github.com/notifications/unsubscribe-auth/AADWlhknMuo02s6ga_VTxM8tiOMSt9Whks5rm9FmgaJpZM4I5tbL .

dandlezzz commented 7 years ago

I need this and will be taking a look at it.