search

lynnfaraday / MUSH

MUSH Softcode and Utilities
8 stars 1 forks source link

+who doesn't report people in TP rooms as IC #32

Closed lynnfaraday closed 11 years ago

lynnfaraday commented 11 years ago

Reported by thirdprophet

-----On Who Data/STATUS:

Original: switch(1,match(loc(%0),v(IDLE_LOUNGE)),[ansi(hx,AFK)],isstaff(%0),[ansi(hb,STF)],u(<Who Functions DBREF>,FUN_IS_IN_TPROOM,%0),[ansi(hm,IC)]%B,match(xget(%0,status),NEW),[ansi(hg,NEW)],match(xget(%0,status),IC),switch(xget(%0,rpsearch),1,[ansi(hR,IC)]%B,[ansi(hr,IC)]%B),[ansi(h,OOC)])

Isolate: u(,FUN_IS_IN_TPROOM,%0)

Replace (first comma to slash): u(/FUN_IS_IN_TPROOM,%0)

This allows the +who/+where to pull the proper STATUS for players in TP Rooms parented to /TP_Room_Parent.

------On Who Functions/FUN_VISIBLE_PLAYERS:

Original: switch(isstaff(%#),1,lwho(),mwho()

Replace (ending close-paren): switch(isstaff(%#),1,lwho(),mwho())

Seemed to me like that was missing a close-paren, not that it was affecting anything in regular operation - but didn't want it to affect other stuff maybe elsewhere. I closed mine off and it hasn't given me any problems.

lynnfaraday commented 11 years ago

Will be fixed in next version. FYI - missing closed parens aren't a problem in Penn if they occur at the very end of a function like that, but still aren't good on principle. (Especially if you later come back and want to add something to that function.)

lynnfaraday commented 11 years ago

NOTE! Requires that you patch the data object STATUS attribute.