lynxthecat / cake-autorate

Eliminate the excess latency and jitter terrorizing your 4G, 5G, LTE, Starlink or other variable rate connection!
https://www.bufferbloat.net
GNU General Public License v2.0
269 stars 24 forks source link

Create version identifier file on install #196

Closed lynxthecat closed 1 year ago

lynxthecat commented 1 year ago

@rany2 can you see a way to have your installer script create a version file cake-autorate_version with the lines:

version = 2.0.0
commit = df5e679

@rany2, @moeller0 and @richb-hanover as a related question, our current structure for /root/cake-autorate/ is:

root@OpenWrt-1:~/cake-autorate# ls -alh
drwxr-xr-x    2 root     root         664 Jun 23 19:01 .
drwxr-xr-x    1 root     root         856 Jun 25 16:17 ..
-rwxr-xr-x    1 root     root       76.0K Jun 20 12:49 cake-autorate.sh
-rw-rw-r--    1 root     root        1.9K Jun 20 13:27 cake-autorate_config.primary.sh
-rw-rw-r--    1 root     root       11.0K Jun 18 10:20 cake-autorate_defaults.sh
-rwxrwxr-x    1 root     root         574 May  5 13:34 cake-autorate_launcher.sh
-rw-rw-r--    1 root     root        2.9K Jun  6 13:35 cake-autorate_lib.sh
-rwxrwxr-x    1 root     root        3.2K Mar 30 21:55 cake-autorate_setup.sh

Should we consider renaming to:

cake-autorate.sh
config.primary.sh
defaults.sh
lib.sh
setup.sh
richb-hanover commented 1 year ago

re: renaming files in /root/cake-autorate: I don't feel strongly either way. It does decrease typing for people doing configuration, but requires a careful check of the documentation to make sure it stays correct.

rany2 commented 1 year ago

@rany2 can you see a way to have your installer script create a version file cake-autorate_version with the lines:

version = 2.0.0
commit = df5e679

That should be easy, I have a rough idea on how to work on that.

lynxthecat commented 1 year ago

Any thoughts on the filenames?

rany2 commented 1 year ago

I am all for it as well, I find the current structure ugly. Though we should really be careful about not messing up docs like @richb-hanover said

rany2 commented 1 year ago

This could be closed now

lynxthecat commented 1 year ago

Yes, kudos @rany2 for implementing these changes.