search

lynxthecat / cake-autorate

Eliminate the excess latency and jitter terrorizing your 4G, 5G, LTE, Starlink or other variable rate connection!
https://www.bufferbloat.net
GNU General Public License v2.0
268 stars 24 forks source link

tsping mode is not compatible with mwan3 #246

Closed patrakov closed 1 year ago

patrakov commented 1 year ago

Some time ago, the code was changed to pass --machine-readable=' ' argument to tsping. Unfortunately, the mwan3 use lte exec wrapper (prefix command) mangles this. It is a bug in mwan3, but bugs there are never fixed. So please try to avoid triggering it. In other words, please try to avoid the need for any special characters that need quoting or otherwise cannot pass through the $* construct, such as spaces. Maybe use $IFS that includes the comma when parsing.

patrakov commented 1 year ago

I have a workaround: instead of ping_prefix_string="mwan3 use lte exec", I can use ping_extra_args="-f 768".

lynxthecat commented 1 year ago

Do you think we should change the code to accommodate this? If so, I wonder if you could issue a pull request?

patrakov commented 1 year ago

Not sure if I have enough time for a pull request.

rany2 commented 1 year ago

I have an idea for a fix, just give me a few moments.

lynxthecat commented 1 year ago

Yay - thanks a lot @rany2!

lynxthecat commented 1 year ago

@rany2 are you still intending to try to fix this?

rany2 commented 1 year ago

@lynxthecat yes, just too busy with other things and forgot about this.