search

lynxthecat / cake-autorate

Eliminate the excess latency and jitter terrorizing your 4G, 5G, LTE, Starlink or other variable rate connection!
https://www.bufferbloat.net
GNU General Public License v2.0
268 stars 24 forks source link

Use comma as delimiter for tsping #249

Closed rany2 closed 1 year ago

rany2 commented 1 year ago

Using "mwan3 use X ..." for tsping does not work properly due to the developers calling "..." using $*. This works around the issue by using , as the delimiter instead.

Fixes #246

lynxthecat commented 1 year ago

Excellent. I'll test this shortly.

lynxthecat commented 1 year ago

Unfortunately this breaks tsping - no reflector responses are read in.

rany2 commented 1 year ago

@lynxthecat I could see responses on my end, at any rate could you try now?

lynxthecat commented 1 year ago

Still not working. Looks like issue with parse_preprocessor?

lynxthecat commented 1 year ago

It works with:

 565 parse_preprocessor()
 566 {
 567         # prepend REFLECTOR_RESPONSE and append timestamp as a checksum
 568         while IFS=', ' read -r timestamp remainder

Won't this issue affect the other pinger binaries too (iputils-ping and fping)?