Closed richb-hanover closed 8 months ago
Ah yes, I see. @rany2 see any easy way(s) to fix?
@lynxthecat yes, it's easy to fix; https://github.com/lynxthecat/cake-autorate/commit/86e991e147e4af738e69e767ae842c85d0598b94 is just missing a quote
@rany2 what about the "unterminated quote" message on line 131?
I wonder if by any chance you could bring in: https://github.com/lynxthecat/cake-autorate/commit/d3ec74c3073b1f53bcded74ad1339ca1679dd8e5 to v3.1?
When trying to install I get:
root@openwrt:~# wget -O /tmp/cake-autorate_setup.sh https://raw.githubusercontent.com/lynxthecat/cake-autorate/v3.1/setup
.sh
Downloading 'https://raw.githubusercontent.com/lynxthecat/cake-autorate/v3.1/setup.sh'
Connecting to 185.199.108.133:443
Writing to '/tmp/cake-autorate_setup.sh'
/tmp/cake-autorate_s 100% |*******************************| 5300 0:00:00 ETA
Download completed (5300 bytes)
root@openwrt:~# sh /tmp/cake-autorate_setup.sh
/tmp/cake-autorate_setup.sh: line 163: syntax error: unterminated quoted string
root@openwrt:~#
I presume if you use ‘master’ rather than ‘v3.1’ it works OK?
Yes, I tried it and installation using the master branch works. (Tested on openwrt 23.05.2). Here is the install log:
@rany2 I've tried to resolve the above-identified issues with pull request #265. Look OK?
Three problems with the INSTALLATION.md file in the 3.1 branch: https://github.com/lynxthecat/cake-autorate/blob/v3.1/INSTALLATION.md
The download URL links to master not v3.1. This causes it to retrieve the prelease version.
If I manually substitute "v3.1" for "master" in the download link, the file comes down OK. But when I execute it, there's an "unterminated quote" message on line 131 (end of the file).
The tables in INSTALLATION.md file are all screwed up.