`master` INSTALLATION.md for 3.1 branch installs 3.2.0-PRERELEASE

[richb-hanover]

Three problems with the INSTALLATION.md file in the 3.1 branch: https://github.com/lynxthecat/cake-autorate/blob/v3.1/INSTALLATION.md

1. The download URL links to master not v3.1. This causes it to retrieve the prelease version.

2. If I manually substitute "v3.1" for "master" in the download link, the file comes down OK. But when I execute it, there's an "unterminated quote" message on line 131 (end of the file).

3. The tables in INSTALLATION.md file are all screwed up.

[lynxthecat]

Ah yes, I see. @rany2 see any easy way(s) to fix?

[rany2]

@lynxthecat yes, it's easy to fix; https://github.com/lynxthecat/cake-autorate/commit/86e991e147e4af738e69e767ae842c85d0598b94 is just missing a quote

[lynxthecat]

@rany2 what about the "unterminated quote" message on line 131?

I wonder if by any chance you could bring in: https://github.com/lynxthecat/cake-autorate/commit/d3ec74c3073b1f53bcded74ad1339ca1679dd8e5 to v3.1?

[vinicentus]

When trying to install I get:

root@openwrt:~# wget -O /tmp/cake-autorate_setup.sh https://raw.githubusercontent.com/lynxthecat/cake-autorate/v3.1/setup
.sh
Downloading 'https://raw.githubusercontent.com/lynxthecat/cake-autorate/v3.1/setup.sh'
Connecting to 185.199.108.133:443
Writing to '/tmp/cake-autorate_setup.sh'
/tmp/cake-autorate_s 100% |*******************************|  5300   0:00:00 ETA
Download completed (5300 bytes)
root@openwrt:~# sh /tmp/cake-autorate_setup.sh
/tmp/cake-autorate_setup.sh: line 163: syntax error: unterminated quoted string
root@openwrt:~#

[lynxthecat]

I presume if you use ‘master’ rather than ‘v3.1’ it works OK?

[vinicentus]

Yes, I tried it and installation using the master branch works. (Tested on openwrt 23.05.2). Here is the install log:

Install log

``` root@openwrt:~# wget -O /tmp/cake-autorate_setup.sh https://raw.githubusercontent.com/lynxthecat/c ake-autorate/master/setup.sh Downloading 'https://raw.githubusercontent.com/lynxthecat/cake-autorate/master/setup.sh' Connecting to 185.199.110.133:443 Writing to '/tmp/cake-autorate_setup.sh' /tmp/cake-autorate_s 100% |*******************************| 5303 0:00:00 ETA Download completed (5303 bytes) root@openwrt:~# sh /tmp/cake-autorate_setup.sh Running opkg update to update package lists: Downloading https://downloads.openwrt.org/releases/23.05.2/targets/ramips/mt7621/packages/Packages.gz Updated list of available packages in /var/opkg-lists/openwrt_core Downloading https://downloads.openwrt.org/releases/23.05.2/targets/ramips/mt7621/packages/Packages.sig Signature check passed. Downloading https://downloads.openwrt.org/releases/23.05.2/packages/mipsel_24kc/base/Packages.gz Updated list of available packages in /var/opkg-lists/openwrt_base Downloading https://downloads.openwrt.org/releases/23.05.2/packages/mipsel_24kc/base/Packages.sig Signature check passed. Downloading https://downloads.openwrt.org/releases/23.05.2/packages/mipsel_24kc/luci/Packages.gz Updated list of available packages in /var/opkg-lists/openwrt_luci Downloading https://downloads.openwrt.org/releases/23.05.2/packages/mipsel_24kc/luci/Packages.sig Signature check passed. Downloading https://downloads.openwrt.org/releases/23.05.2/packages/mipsel_24kc/packages/Packages.gz Updated list of available packages in /var/opkg-lists/openwrt_packages Downloading https://downloads.openwrt.org/releases/23.05.2/packages/mipsel_24kc/packages/Packages.sig Signature check passed. Downloading https://downloads.openwrt.org/releases/23.05.2/packages/mipsel_24kc/routing/Packages.gz Updated list of available packages in /var/opkg-lists/openwrt_routing Downloading https://downloads.openwrt.org/releases/23.05.2/packages/mipsel_24kc/routing/Packages.sig Signature check passed. Downloading https://downloads.openwrt.org/releases/23.05.2/packages/mipsel_24kc/telephony/Packages.gz Updated list of available packages in /var/opkg-lists/openwrt_telephony Downloading https://downloads.openwrt.org/releases/23.05.2/packages/mipsel_24kc/telephony/Packages.sig Signature check passed. Installing bash, iputils-ping and fping packages: Installing bash (5.2.15-1) to root... Downloading https://downloads.openwrt.org/releases/23.05.2/packages/mipsel_24kc/packages/bash_5.2.15-1_mipsel_24kc.ipk Installing terminfo (6.4-2) to root... Downloading https://downloads.openwrt.org/releases/23.05.2/packages/mipsel_24kc/base/terminfo_6.4-2_mipsel_24kc.ipk Installing libncurses6 (6.4-2) to root... Downloading https://downloads.openwrt.org/releases/23.05.2/packages/mipsel_24kc/base/libncurses6_6.4-2_mipsel_24kc.ipk Installing libreadline8 (8.2-1) to root... Downloading https://downloads.openwrt.org/releases/23.05.2/packages/mipsel_24kc/base/libreadline8_8.2-1_mipsel_24kc.ipk Installing iputils-ping (20211215-2) to root... Downloading https://downloads.openwrt.org/releases/23.05.2/packages/mipsel_24kc/packages/iputils-ping_20211215-2_mipsel_24kc.ipk Installing kmod-crypto-md5 (5.15.137-1) to root... Downloading https://downloads.openwrt.org/releases/23.05.2/targets/ramips/mt7621/packages/kmod-crypto-md5_5.15.137-1_mipsel_24kc.ipk Installing fping (5.0-1) to root... Downloading https://downloads.openwrt.org/releases/23.05.2/packages/mipsel_24kc/packages/fping_5.0-1_mipsel_24kc.ipk Configuring terminfo. Configuring libncurses6. Configuring libreadline8. Configuring bash. Configuring kmod-crypto-md5. Configuring iputils-ping. Configuring fping. Installing cake-autorate in /root/cake-autorate... Now edit the config.primary.sh file as described in: https://github.com/lynxthecat/cake-autorate/tree/master#installation-on-openwrt 3.2.0-PRERELEASE successfully installed, but not yet running Start the software manually with: cd /root/cake-autorate; ./cake-autorate.sh Run as a service with: service cake-autorate enable; service cake-autorate start root@openwrt:~# ```

[lynxthecat]

@rany2 I've tried to resolve the above-identified issues with pull request #265. Look OK?