Closed lynxthecat closed 6 months ago
I don't like defaulting this to 2Mbit/s because of ADSL. If we go forward with this I think there needs to be a sanity check that makes sure that the connection_active_thr_kbps is lower than either min dl/ul shaper rate.
If the check is added then at least ADSL users would notice this misconfiguration.
Good point. I added the sanity check.
The default idle threshold of 1MBit/s seems to be too low for a typical set of home IoT devices, resulting in the sleep activation logic never triggering - see here. In any case, it seems apt to add this as one of the configuration options present in config.primary.sh.
And the term 'instance' is more appropriate than 'interface' in respect of config.x.sh.