Closed moeller0 closed 4 months ago
@moeller0 how about skipping any bad line and then continuing on with any remaining lines?
@lynxthecat your log should never be broken like this in the first place, I think it's appropriate for it to fail. Making this a warning will just mean that it will be ignored
So far the incomplete line was always the last in the file... so abortiung the parsing there seems fine. If the log contains incomplete lines higher up, I will need to revisit this.
There could also be situations in which incomplete log lines are present not owing to any fault of cake-autorate, e.g. if users mess about with tail and merging files, etc.
I am more inclined to let users that break their log files like that keep both pieces...
It is one thing to not crash on a problematic logfile, but a whole different game trying to deduce what to trust in a non conforming logfile... As they say, trying to make things fool proof just creates selective pressure to evolve 'better' fools ;)
On encountering an incomplete line, stop parsing, and work with the complete records parsed so far.