search

lynxthecat / cake-autorate

Eliminate the excess latency and jitter terrorizing your 4G, 5G, LTE, Starlink or other variable rate connection!
https://www.bufferbloat.net
GNU General Public License v2.0
263 stars 24 forks source link

Actually store the SUMMARY data to the output struct #280

Closed moeller0 closed 4 months ago

moeller0 commented 4 months ago

While we are not using this right now, no reason to not save it to the mat file. Also fix a comment up...

The previous changes fixed SUMMARY parsing, but this now actually stores the SUMMARY data to the matfile and makes it available.

rany2 commented 4 months ago

Are you opposed to running the code through a formatter? There's some inconsistent indentation

moeller0 commented 4 months ago

Well, I appreciate code review, but talking about white space is IMHO mostly busy work (I am not opposed to some level of consistency, but in the grand scheme of things, I consider this to be cosmetic issues)... That said it appears on my new machine I need to change the editor defaults to my previous defaults, I assume we mostly talking spaces versus tabs?

rany2 commented 4 months ago

I don't disagree. It is just a minimum effort change to run it through a code reformatter, but if it's not causing any issues on your end then there is no need.